Hi, On Tue, Mar 22, 2011 at 04:53:28PM +0530, Hema Kalliguddi wrote: > >then pass NULL, you don't know the value of that dev by the > >time you use > >it. Either you build a real device, or pass NULL and fix > >omap4430_phy_init() to not use dev_*() macros or you will be > >following a > >NULL pointer. > > OK. I will pass the NULL. There is no point in building the real device > when > USB itself is disabled. BTW, the semantics of that part of the code is quite screwed up: we need to call omap4430_phy_init() to *power down* the PHY. Also, after powering down the phy, you get the clocks, that's really screwed up. But now, can only fix that for next merge window. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html