On Tue, Mar 22, 2011 at 04:44:36PM +0530, Hema Kalliguddi wrote: > Felipe, > > >-----Original Message----- > >From: Felipe Balbi [mailto:balbi@xxxxxx] > >Sent: Tuesday, March 22, 2011 4:36 PM > >To: Hema HK > >Cc: linux-usb@xxxxxxxxxxxxxxx; Felipe Balbi > >Subject: Re: [PATCH] usb: otg: OMAP4430: Powerdown the > >internal PHY when USB is disabled > > > >On Tue, Mar 22, 2011 at 04:21:57PM +0530, Hema HK wrote: > >> Powerdown the internal UTMI PHY when USB is not enabled. This will > >> allow the OMAP core domain to transition to retention and offmode. > >> > >> Signed-off-by: Hema HK <hemahk@xxxxxx> > >> Cc: Felipe Balbi <balbi@xxxxxx> > >> --- > >> arch/arm/mach-omap2/usb-musb.c | 4 ++++ > >> 1 files changed, 4 insertions(+), 0 deletions(-) > >> > >> Index: linux-2.6/arch/arm/mach-omap2/usb-musb.c > >> =================================================================== > >> --- linux-2.6.orig/arch/arm/mach-omap2/usb-musb.c > >> +++ linux-2.6/arch/arm/mach-omap2/usb-musb.c > >> @@ -169,5 +169,9 @@ void __init usb_musb_init(struct omap_mu > >> #else > >> void __init usb_musb_init(struct omap_musb_board_data *board_data) > >> { > >> + struct device *dev; > >> + > >> + if (cpu_is_omap44xx()) > >> + omap4430_phy_init(dev); > > > >using uninitialized variable ?? > > Yep. At this point in time dev may not be available as there is no > omap_device_build() > done. And also this dev is dummy dev used for clok_get() instead of > passing > NULL in the phy_init function. > > Otherwise I have to introduce one more exported function to > just powerdown the PHY and use here. then pass NULL, you don't know the value of that dev by the time you use it. Either you build a real device, or pass NULL and fix omap4430_phy_init() to not use dev_*() macros or you will be following a NULL pointer. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
