Felipe, >-----Original Message----- >From: Felipe Balbi [mailto:balbi@xxxxxx] >Sent: Tuesday, March 22, 2011 5:02 PM >To: Hema HK >Cc: linux-usb@xxxxxxxxxxxxxxx; Felipe Balbi >Subject: Re: [PATCH 2/2] usb: musb: Calling VBUS pulsing API >when SRP is initiated. > >On Tue, Mar 22, 2011 at 04:54:22PM +0530, Hema HK wrote: >> Call VBUS pulsing API when there is SRP initiation from user space. >> >> Signed-off-by: Hema HK <hemahk@xxxxxx> >> Cc: Felipe Balbi <balbi@xxxxxx> >> --- >> drivers/usb/musb/musb_gadget.c | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> Index: linux-2.6/drivers/usb/musb/musb_gadget.c >> =================================================================== >> --- linux-2.6.orig/drivers/usb/musb/musb_gadget.c >> +++ linux-2.6/drivers/usb/musb/musb_gadget.c >> @@ -1549,6 +1549,10 @@ static int musb_gadget_wakeup(struct usb >> break; >> } >> >> + spin_unlock_irqrestore(&musb->lock, flags); >> + otg_start_srp(musb->xceiv); >> + spin_lock_irqsave(&musb->lock, flags); > >don't reenable IRQs just yet, do you need IRQs to be enabled or is >spin_unlock() enough to call otg_start_srp() ?? Since otg_start_srp() has I2C transfers, IRQ enable is required. Regards, Hema > >-- >balbi > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
