Re: [PATCH 2/2] usb: musb: Calling VBUS pulsing API when SRP is initiated.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Mar 22, 2011 at 05:22:31PM +0530, Hema Kalliguddi wrote:
> >> Index: linux-2.6/drivers/usb/musb/musb_gadget.c
> >> ===================================================================
> >> --- linux-2.6.orig/drivers/usb/musb/musb_gadget.c
> >> +++ linux-2.6/drivers/usb/musb/musb_gadget.c
> >> @@ -1549,6 +1549,10 @@ static int musb_gadget_wakeup(struct usb
> >>  				break;
> >>  		}
> >>
> >> +		spin_unlock_irqrestore(&musb->lock, flags);
> >> +		otg_start_srp(musb->xceiv);
> >> +		spin_lock_irqsave(&musb->lock, flags);
> >
> >don't reenable IRQs just yet, do you need IRQs to be enabled or is
> >spin_unlock() enough to call otg_start_srp() ??
> 
> Since otg_start_srp() has I2C transfers, IRQ enable is required.

aa, true, sorry about that.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux