> -----Original Message----- > From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx] > Sent: Friday, January 07, 2011 12:37 AM > To: Sergei Shtylyov > Cc: linux-usb@xxxxxxxxxxxxxxx; Xu, Andiry > Subject: Re: [PATCH 07/11] xHCI: remove redundant parameter in > giveback_first_trb() > > On Thu, Jan 06, 2011 at 03:16:32PM +0300, Sergei Shtylyov wrote: > > Hello. > > > > On 05-01-2011 19:41, Sarah Sharp wrote: > > > > >>>From: Andiry Xu <andiry.xu@xxxxxxx> > > > > >>>Parameter *td is not used in giveback_first_trb(). Remove it. > > > > >>>Signed-off-by: Andiry Xu<andiry.xu@xxxxxxx> > > >>>Signed-off-by: Sarah Sharp<sarah.a.sharp@xxxxxxxxxxxxxxx> > > >>>--- > > >>> drivers/usb/host/xhci-ring.c | 14 ++++++-------- > > >>> 1 files changed, 6 insertions(+), 8 deletions(-) > > > > >>>diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci- > ring.c > > >>>index 55dc156..59f81b5 100644 > > >>>--- a/drivers/usb/host/xhci-ring.c > > >>>+++ b/drivers/usb/host/xhci-ring.c > > >>[...] > > >>>@@ -3006,10 +3006,8 @@ static int xhci_queue_isoc_tx(struct xhci_hcd > *xhci, gfp_t mem_flags, > > >>> } > > >>> } > > >>> > > >>>- wmb(); > > >>>- start_trb->field[3] |= start_cycle; > > >>>- > > >>>- xhci_ring_ep_doorbell(xhci, slot_id, ep_index, urb->stream_id); > > >>>+ giveback_first_trb(xhci, slot_id, ep_index, urb->stream_id, > > >>>+ start_cycle, start_trb); > > > > >> Hm, this change is not descripbed... > > > > >It's just replacing an instance where the code inside > > >giveback_first_trb() was used instead of calling the actual function, > > >for whatever reason. It's not changing behavior. Yes, it probably > > >should have been a separate patch, > > > > Not necessarily. But it should've been described at least. > > Andiry, > > It's true that anyone who's not familiar with the giveback_first_trb() > function would wonder where this change came from. Since Greg isn't > going to take these patchset until after the merge, can you please > respin it with a comment about replacing code equivalent to > giveback_first_trb() in xhci_queue_isoc_tx() with a call to the actual > function. The description is a bit terse. > Sure, will do. Thanks, Andiry -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
