Hello.
On 05-01-2011 19:41, Sarah Sharp wrote:
From: Andiry Xu <andiry.xu@xxxxxxx>
Parameter *td is not used in giveback_first_trb(). Remove it.
Signed-off-by: Andiry Xu<andiry.xu@xxxxxxx>
Signed-off-by: Sarah Sharp<sarah.a.sharp@xxxxxxxxxxxxxxx>
---
drivers/usb/host/xhci-ring.c | 14 ++++++--------
1 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 55dc156..59f81b5 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
[...]
@@ -3006,10 +3006,8 @@ static int xhci_queue_isoc_tx(struct xhci_hcd *xhci, gfp_t mem_flags,
}
}
- wmb();
- start_trb->field[3] |= start_cycle;
-
- xhci_ring_ep_doorbell(xhci, slot_id, ep_index, urb->stream_id);
+ giveback_first_trb(xhci, slot_id, ep_index, urb->stream_id,
+ start_cycle, start_trb);
Hm, this change is not descripbed...
It's just replacing an instance where the code inside
giveback_first_trb() was used instead of calling the actual function,
for whatever reason. It's not changing behavior. Yes, it probably
should have been a separate patch,
Not necessarily. But it should've been described at least.
but why didn't you object when these
patches were sent by Andiry on December 20?
Sorry, I simply didn't look at that posting. I tend to not read the mails
over 5K in size. :-)
Sarah Sharp
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
