Hello. On 06-01-2011 5:55, Bob Liu wrote:
Blackfin platform doesn't support 32bits musbdma registers, so change back to use musb_read/writew instead of musb_read/writel and simply some format casts.
Instead, patch the definition of musb_readl()/writel() for blackfin. Other archs _do_ support 32 bit reads/writes and this patch will pose an impact on those.
How -- if it only patches the defintion under #ifdef CONFIG_BLACKFIN?
aa, my bad, I read it wrongly. Still, it'd be better to patch musb_readl/writel() instead of patching all uses of musb_readl() on every Blackfin code.
If patched to musb_readl/writel() itself, I am afraid there maybe or will have some other blackfin musb registers which can do 32bits read and write correctly,
If you look at the actual defintiotions of musb_readl()/musb_writel() for Blackfin, you'll see that they do 16-bit accesses ISO 32-bit. Yes, they just truncate 32-bit value on writes. :-/
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
