On Wed, Jan 5, 2011 at 10:13 PM, Felipe Balbi <balbi@xxxxxx> wrote: > Hi, > > On Wed, Jan 05, 2011 at 03:58:10PM +0300, Sergei Shtylyov wrote: >> On 05-01-2011 15:53, Felipe Balbi wrote: >> >> >>Blackfin platform doesn't support 32bits musbdma registers, so change back to >> >>use musb_read/writew instead of musb_read/writel and simply some format casts. >> >> >Instead, patch the definition of musb_readl()/writel() for blackfin. >> >Other archs _do_ support 32 bit reads/writes and this patch will pose an >> >impact on those. >> >> Â ÂHow -- if it only patches the defintion under #ifdef CONFIG_BLACKFIN? > > aa, my bad, I read it wrongly. Still, it'd be better to patch > musb_readl/writel() instead of patching all uses of musb_readl() on > every Blackfin code. > If patched to musb_readl/writel() itself, I am afraid there maybe or will have some other blackfin musb registers which can do 32bits read and write correctly, so I just change the use of hsdma musb_readl() in order to not effect other 32bits registers read/write. Thanks for your review. -- Regards, --Bob -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
