Re: [PATCH] usb: ehci-omap: Use dev_err in probing time error prints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 6 Jan 2011 19:13:26 -0800 (PST)
David Brownell <david-b@xxxxxxxxxxx> wrote:

> the rule I've used for quite a few years is
> different:
> 
> If a user seeing the message is expected to be able
> to do anything with it, like fix the problem THEN it
> is appropriate to call it an err().  Or maybe a
> warn(). On the other
> hand if it's a debug message that only developers are
> really expected to cope with, aand even then maybe
> only with source code  in hand then use dbg().
> That's aclear distinction, an helps ensure that
> end users can eventually get good docs for errors,
> without being required to become developers, able
> to debug system esoterica.
> 
Umm.. looks like most of the error prints in omap_start_ehc fall into
developer category and only errors from usb_create_hcd and usb_add_hcd
should hit the end user as they are dealing with memory allocation.

I'll update the patch and resend.


-- 
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux