Re: [PATCH] usb: ehci-omap: Use dev_err in probing time error prints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




--- On Thu, 1/6/11, Jarkko Nikula <jhnikula@xxxxxxxxx> wrote:

> From: Jarkko Nikula <jhnikula@xxxxxxxxx>
> Subject: [PATCH] usb: ehci-omap: Use dev_err in probing time error prints

the rule I've used for quite a few years is
different:

If a user seeing the message is expected to be able
to do anything with it, like fix the problem THEN it
is appropriate to call it an err().  Or maybe a
warn(). On the other
hand if it's a debug message that only developers are
really expected to cope with, aand even then maybe
only with source code  in hand then use dbg().
That's aclear distinction, an helps ensure that
end users can eventually get good docs for errors,
without being required to become developers, able
to debug system esoterica.

In short, users should report all messages when things go wrong, but developers  only have very
limited time to invest describing what end users should do with ) for (err) messages.  (and
likewise, making the messages comprehensible and
prescriptive to non-guru users ... which is a waste
of time and effort for dbg() messages, which often
require source code to make sense of.

The goal of diagnostics is sorting problems, and
there are two communities doing that.  One is the
end users.  Only developers should use  dbg(), and
the rest are for end users, in a system that's at
all well directed.

Set things up so users don't need dbg().




--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux