> -----Original Message----- > From: Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxx] > Sent: Wednesday, January 05, 2011 8:29 PM > To: Sarah Sharp > Cc: linux-usb@xxxxxxxxxxxxxxx; Xu, Andiry > Subject: Re: [PATCH 07/11] xHCI: remove redundant parameter in > giveback_first_trb() > > Hello. > > On 05-01-2011 10:38, Sarah Sharp wrote: > > > From: Andiry Xu <andiry.xu@xxxxxxx> > > > Parameter *td is not used in giveback_first_trb(). Remove it. > > > Signed-off-by: Andiry Xu <andiry.xu@xxxxxxx> > > Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> > > --- > > drivers/usb/host/xhci-ring.c | 14 ++++++-------- > > 1 files changed, 6 insertions(+), 8 deletions(-) > > > diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c > > index 55dc156..59f81b5 100644 > > --- a/drivers/usb/host/xhci-ring.c > > +++ b/drivers/usb/host/xhci-ring.c > [...] > > @@ -3006,10 +3006,8 @@ static int xhci_queue_isoc_tx(struct xhci_hcd > *xhci, gfp_t mem_flags, > > } > > } > > > > - wmb(); > > - start_trb->field[3] |= start_cycle; > > - > > - xhci_ring_ep_doorbell(xhci, slot_id, ep_index, urb->stream_id); > > + giveback_first_trb(xhci, slot_id, ep_index, urb->stream_id, > > + start_cycle, start_trb); > > Hm, this change is not descripbed... > As Sarah said, it just uses a function calling to replace the direct code, driver behavior does not change. It's also giveback_first_trb() related so I combine it as one patch. I think it's OK. Thanks, Andiry -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
