Hello. On 15-12-2010 12:06, Felipe Balbi wrote:
Did you actually try the branch ?
No. Besides, it's not convenient to review the patches in git branch.
yeah, my bad, should've re-sent. I broke the patches when rebasing on top of greg/usb-next. Was writing them on top of linus/master previously.
still wouldn't hurt to run a make on the actual branch.
I will try it today.
Thanks, it's on top of greg/usb-next.
I have tried to sanity check it on DA830 and after fixing the compilation erro in the glue layer, and fixing the fallout of another patch that made musb_init_controller() fail, I got it seemingly working as built-in, and failing as module:
Now I have also (at last!) tried it on DaVinci DM6446 and it does *not* work even as built-in. The only thing that gets into the boot log is this:
musb-hdrc: version 6.0, pio, host, debug=0
I'm seeing only /sys/devices/platfrom/musb-davinci/, with no driver/ subdirectory, so I guess that the platform device somehow doesn't get probed; I'll spend some time on investigation...
It's DaVinci glue's platform_driver_probe() being called before the platform device is registered. The latter happens late for DaVinci, only once the I2C GPIO expanders get registered. You use subsys_initcall() for initializing the glue layers, and musb_core.c uses fs_initcall() which happens later -- that's why it worked before and stopped now...
glue layer has to probe before musb_core, it sets up the platform_device for that.
Understood. I think we just can register the platfrom device earlier on DaVinci...
> Now that's too late to cancel the pull request. We will fix > during -rc. Sorry. OK. I think I'll try to fix it in the DaVinci tree... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
