Re: [PATCH v2 01/25] usb: otg: add unified otg_notify function for usb_otg_event notification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 11, 2010 at 12:56:06PM +0800, Wu, Hao wrote:
> >> +enum usb_otg_events {
> >> +	/* according to OTG Spec */
> >> +	USB_OTG_CONNECT,	/* a_conn/b_conn */
> >> +	USB_OTG_DISCON,
> >> +	USB_OTG_HOST_SUSP,	/* bus request */
> >> +	USB_OTG_HOST_RESU,
> >> +	USB_OTG_DEV_SUSP,	/* bus suspend/resume event */
> >> +	USB_OTG_DEV_RESU,
> >
> >    Why use strange contractions like that and not just call it SUSPEND/RESUME?
> 
> It seems a little long if no contractions. Do you see if it is fine to keep them here?

Do we somehow now have a limit on lengths of enumerated types?  Please
spell it all out.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux