>> +enum usb_otg_events { >> + /* according to OTG Spec */ >> + USB_OTG_CONNECT, /* a_conn/b_conn */ >> + USB_OTG_DISCON, >> + USB_OTG_HOST_SUSP, /* bus request */ >> + USB_OTG_HOST_RESU, >> + USB_OTG_DEV_SUSP, /* bus suspend/resume event */ >> + USB_OTG_DEV_RESU, > > Why use strange contractions like that and not just call it SUSPEND/RESUME? It seems a little long if no contractions. Do you see if it is fine to keep them here? >> + >> + /* others */ >> + USB_OTG_HOST_ACTIVE, /* host driver added/active */ >> + USB_OTG_HOST_STOP, /* host driver removed/stopped */ >> + USB_OTG_DEV_ACTIVE, /* udc driver added/active */ >> + USB_OTG_DEV_STOP, /* udc driver removed/stopped */ >> + >> + /* Battery charging Spec 1.1, requires different charging >> + * current in FullSpeed mode/HighSpeed mode with CDP, in >> + * such case, transceiver needs these events to update the >> + * current limitation */ > > The preferred style of multi-line comments is this: Ok, will update it. Thanks for your comment. : ) Hao -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html