Re: [PATCH v2 01/25] usb: otg: add unified otg_notify function for usb_otg_event notification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Hao Wu wrote:

This patch adds a unified otg_notify function to otg_transceiver data
structure. It is used for USB host/peripheral to notify otg related event
to otg_transceiver.

Signed-off-by: Hao Wu <hao.wu@xxxxxxxxx>
[...]

diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h
index 0a5b371..97292ab 100644
--- a/include/linux/usb/otg.h
+++ b/include/linux/usb/otg.h
@@ -35,6 +35,29 @@ enum usb_otg_state {
 	OTG_STATE_A_VBUS_ERR,
 };
+enum usb_otg_events {
+	/* according to OTG Spec */
+	USB_OTG_CONNECT,	/* a_conn/b_conn */
+	USB_OTG_DISCON,
+	USB_OTG_HOST_SUSP,	/* bus request */
+	USB_OTG_HOST_RESU,
+	USB_OTG_DEV_SUSP,	/* bus suspend/resume event */
+	USB_OTG_DEV_RESU,

   Why use strange contractions like that and not just call it SUSPEND/RESUME?

+
+	/* others */
+	USB_OTG_HOST_ACTIVE,	/* host driver added/active */
+	USB_OTG_HOST_STOP,	/* host driver removed/stopped */
+	USB_OTG_DEV_ACTIVE,	/* udc driver added/active */
+	USB_OTG_DEV_STOP,	/* udc driver removed/stopped */
+
+	/* Battery charging Spec 1.1, requires different charging
+	 * current in FullSpeed mode/HighSpeed mode with CDP, in
+	 * such case, transceiver needs these events to update the
+	 * current limitation */

   The preferred style of multi-line comments is this:

/*
 * bla
 * bla
 */

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux