RE: [PATCH v2 04/25] ehci: Support for Intel Moorestown MPH and OTG host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
>> index 27115b4..46abdb8 100644
>> --- a/drivers/usb/core/hub.c
>> +++ b/drivers/usb/core/hub.c
>> @@ -21,6 +21,7 @@
>>  #include <linux/usbdevice_fs.h>
>>  #include <linux/usb/hcd.h>
>>  #include <linux/usb/quirks.h>
>> +#include <linux/usb/otg.h>
>>  #include <linux/kthread.h>
>>  #include <linux/mutex.h>
>>  #include <linux/freezer.h>
>> @@ -1607,6 +1608,11 @@ void usb_disconnect(struct usb_device **pdev)
>>  	 */
>>  	device_del(&udev->dev);
>>
>> +	/* Notify OTG disconnect event, only for USB device which is
>> +	 * directly connected to root hub */
>> +	if (udev->parent && udev->parent->parent == NULL)
>> +		otg_notify_event(USB_OTG_DISCON);
>
>I thought we went through this already, why not just use the _existing_
>notification process?  No need to create your own here.
>

Hi Greg,

Thanks for your help on code review.

Could you help to tell me which existing notification process is recommended for this purpose?
Thanks in advance.:)

Hao
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux