Re: [PATCH v2 04/25] ehci: Support for Intel Moorestown MPH and OTG host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 11, 2010 at 12:40:47AM +0800, Hao Wu wrote:
> The Intel Moorestown platform has EHCI MPH and EHCI OTG host. This patch adds
> PCI probe part for them. The HNP part and SRAM part will be added in another
> patch. This patch depends on patch which adds unified otg_notify function.
> 
> Signed-off-by: Jacob Pan <jacob.jun.pan@xxxxxxxxx>
> Signed-off-by: Alek Du <alek.du@xxxxxxxxx>
> Signed-off-by: Hao Wu <hao.wu@xxxxxxxxx>
> ---
>  drivers/usb/core/hub.c                |   11 ++
>  drivers/usb/host/ehci-hcd.c           |   18 +++
>  drivers/usb/host/ehci-hub.c           |    6 +-
>  drivers/usb/host/ehci-intel-mid-pci.c |  188 +++++++++++++++++++++++++++++++++
>  drivers/usb/host/ehci-pci.c           |   14 +++
>  5 files changed, 235 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/usb/host/ehci-intel-mid-pci.c
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 27115b4..46abdb8 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -21,6 +21,7 @@
>  #include <linux/usbdevice_fs.h>
>  #include <linux/usb/hcd.h>
>  #include <linux/usb/quirks.h>
> +#include <linux/usb/otg.h>
>  #include <linux/kthread.h>
>  #include <linux/mutex.h>
>  #include <linux/freezer.h>
> @@ -1607,6 +1608,11 @@ void usb_disconnect(struct usb_device **pdev)
>  	 */
>  	device_del(&udev->dev);
>  
> +	/* Notify OTG disconnect event, only for USB device which is
> +	 * directly connected to root hub */
> +	if (udev->parent && udev->parent->parent == NULL)
> +		otg_notify_event(USB_OTG_DISCON);

I thought we went through this already, why not just use the _existing_
notification process?  No need to create your own here.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux