On Tue, Nov 9, 2010 at 9:19 PM, Felipe Balbi <balbi@xxxxxx> wrote: > On Tue, Nov 09, 2010 at 07:14:36AM -0600, Bob Liu wrote: >> >> I found out the cause of this problem on our platform. >> >> According to our hardware reference manuel, big changes are needed to >> support double buffer(eg. it depends on SOF interrupt and rxcsr >> fifofull bit etc). We need more time to work on these. > > good, then we can continue with these other patches. > >> So Felipe, >> is patch like this can be accepted ? >> ============ >> - Â Â Â Â Â Â Â if (musb->hwvers < MUSB_HWVERS_2000) >> Â Â Â Â Â Â Âif (musb->hwvers < MUSB_HWVERS_2000 && !musb->dyn_fifo) >> Â Â Â Â Â Â Â Â Â Â Âmusb_writew(regs, MUSB_TXMAXP, >> hw_ep->max_packet_sz_tx); >> Â Â Â Â Â Â Âelse >> Â Â Â Â Â Â Â Â Â Â Âmusb_writew(regs, MUSB_TXMAXP, >> musb_ep->packet_sz | (musb_ep->hb_mult << 11)); >> >> or >> >> - Â Â Â Â Â Â Â if (musb->hwvers < MUSB_HWVERS_2000) >> Â Â Â Â Â Â Âif (musb->hwvers < MUSB_HWVERS_2000 && >> musb->config->gpio_vrsel) >> Â Â Â Â Â Â Â Â Â Â Âmusb_writew(regs, MUSB_TXMAXP, >> hw_ep->max_packet_sz_tx); >> Â Â Â Â Â Â Âelse >> Â Â Â Â Â Â Â Â Â Â Âmusb_writew(regs, MUSB_TXMAXP, >> musb_ep->packet_sz | (musb_ep->hb_mult << 11)); > > I don't understand this patch. Please send a correct 'git diff' patch. > okay. >> If not, are there any suggestions how to deal with this problem. >> How to support no dyn_fifo and only support single buffer platform ? > > dynamic fifo sizing with single buffering is already supported as is. > Just use the correct fifo_mode table. > I mean the case config endpoint from hardware instead of table,in that case, how to support single buffer ? Because after added this patch, then double buffer will always auto enabled on our platform. Currently we don't support double buffer and we are using ep_config_from_hw(), we need a way to control using single buffer or double buffer, any suggestion is welcome. -- Thanks, --Bob -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
