Re: [PATCH 04/11] USB: musb: gadget: fix MUSB_TXMAXP and MUSB_RXMAXP configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/11/9 Bob Liu <lliubbo@xxxxxxxxx>:
> Hi, Ming
>
> I found out the cause of this problem on our platform.
>
> According to our hardware reference manuel, big changes are needed to
> support double buffer(eg. it depends on SOF interrupt and rxcsr
> fifofull bit etc). We need more time to work on these.

Could you give which page or which section about the description?
Seems bfin otg TRM is open.

If not, could you describe the problem in more detail?

>
> So Felipe,
> is patch like this can be accepted ?
> ============
> -               if (musb->hwvers < MUSB_HWVERS_2000)
>               if (musb->hwvers < MUSB_HWVERS_2000 && !musb->dyn_fifo)
>                       musb_writew(regs, MUSB_TXMAXP, hw_ep->max_packet_sz_tx);
>               else
>                       musb_writew(regs, MUSB_TXMAXP,
> musb_ep->packet_sz | (musb_ep->hb_mult << 11));
>
> or
>
> -               if (musb->hwvers < MUSB_HWVERS_2000)
>               if (musb->hwvers < MUSB_HWVERS_2000 && musb->config->gpio_vrsel)
>                       musb_writew(regs, MUSB_TXMAXP, hw_ep->max_packet_sz_tx);
>               else
>                       musb_writew(regs, MUSB_TXMAXP,
> musb_ep->packet_sz | (musb_ep->hb_mult << 11));
>

I don't think either one can be accepted.

This two still can make g_ether or full speed test broken in bfin,
can't this?

> If not, are there any suggestions how to deal with this problem.
> How to support no dyn_fifo and only support single buffer platform ?

What is the problem? See above.

-- 
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux