Re: [PATCH 04/11] USB: musb: gadget: fix MUSB_TXMAXP and MUSB_RXMAXP configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 09, 2010 at 07:14:36AM -0600, Bob Liu wrote:
I found out the cause of this problem on our platform.

According to our hardware reference manuel, big changes are needed to
support double buffer(eg. it depends on SOF interrupt and rxcsr
fifofull bit etc). We need more time to work on these.

good, then we can continue with these other patches.

So Felipe,
is patch like this can be accepted ?
============
-               if (musb->hwvers < MUSB_HWVERS_2000)
              if (musb->hwvers < MUSB_HWVERS_2000 && !musb->dyn_fifo)
                      musb_writew(regs, MUSB_TXMAXP, hw_ep->max_packet_sz_tx);
              else
                      musb_writew(regs, MUSB_TXMAXP,
musb_ep->packet_sz | (musb_ep->hb_mult << 11));

or

-               if (musb->hwvers < MUSB_HWVERS_2000)
              if (musb->hwvers < MUSB_HWVERS_2000 && musb->config->gpio_vrsel)
                      musb_writew(regs, MUSB_TXMAXP, hw_ep->max_packet_sz_tx);
              else
                      musb_writew(regs, MUSB_TXMAXP,
musb_ep->packet_sz | (musb_ep->hb_mult << 11));

I don't understand this patch. Please send a correct 'git diff' patch.

If not, are there any suggestions how to deal with this problem.
How to support no dyn_fifo and only support single buffer platform ?

dynamic fifo sizing with single buffering is already supported as is.
Just use the correct fifo_mode table.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux