Re: [RFC] [PATCH 2/7] usb: ehci-omap: don't execute OMAP3-specific code on non-OMAP3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 19, 2010 at 01:49:32AM +0200, ext Keshava Munegowda wrote:
@@ -297,194 +297,184 @@ static int omap_start_ehc(struct ehci_hc
               udelay(10);
       }

-       /* Enable Clocks for USBHOST */
-       omap->usbhost_ick = clk_get(omap->dev, "usbhost_ick");
-       if (IS_ERR(omap->usbhost_ick)) {
-               ret =  PTR_ERR(omap->usbhost_ick);
-               goto err_host_ick;
-       }
-       clk_enable(omap->usbhost_ick);
+       if (cpu_is_omap44xx()) {
+               /* TODO */

please don't. Come back when you have clock framework support for omap4, this patch is anyway useless as you will revert it as soon as clock framework support is done. NAK

if you don't have clk support on omap4, make clk_* empty stubs.

--
balbi

DefectiveByDesign.org
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux