Re: [PATCH 03/12] usb: dwc2: Allow entering clock gating from USB_SUSPEND interrupt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13.04.2021 10:16, Artur Petrosyan wrote:

If core doesn't support hibernation or partial power
down power saving options, power can still be saved
using clock gating on all the clocks.

- Added entering clock gating state from USB_SUSPEND
   interrupt.

Signed-off-by: Artur Petrosyan <Arthur.Petrosyan@xxxxxxxxxxxx>
Acked-by: Minas Harutyunyan <Minas.Harutyunyan@xxxxxxxxxxxx>
---
  drivers/usb/dwc2/core_intr.c | 10 +++++++---
  1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_intr.c
index 8c0152b514be..ab7fe303c0f9 100644
--- a/drivers/usb/dwc2/core_intr.c
+++ b/drivers/usb/dwc2/core_intr.c
@@ -529,14 +529,18 @@ static void dwc2_handle_usb_suspend_intr(struct dwc2_hsotg *hsotg)
  				/* Ask phy to be suspended */
  				if (!IS_ERR_OR_NULL(hsotg->uphy))
  					usb_phy_set_suspend(hsotg->uphy, true);
-			}
-
-			if (hsotg->hw_params.hibernation) {
+			} else if (hsotg->hw_params.hibernation) {
  				ret = dwc2_enter_hibernation(hsotg, 0);
  				if (ret && ret != -ENOTSUPP)
  					dev_err(hsotg->dev,
  						"%s: enter hibernation failed\n",
  						__func__);
+			} else {
+				/*
+				 * If not hibernation nor partial power down are supported,

   s/not/neither/?

[...]

MBR, Sergei



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux