On Tue, Aug 18, 2020 at 11:49:43PM +0300, Sergei Shtylyov wrote:
> On 8/18/20 8:29 PM, Alan Stern wrote:
>
> >>> + } else {
> >>> printk(KERN_ERR "%s: error %d registering device "
> >>> " driver %s\n",
> >>
> >> Unrelated but... hm, this string literal seems weird. GregKH, would it be OK if we fix it?
> >>
> >>> usbcore_name, retval, new_udriver->name);
> >
> > Indeed, an extra tab character snuck in there by mistake. It has been
> > present ever since 2006, when the routine was originally added by commit
> > 8bb54ab573ec ("usbcore: add usb_device_driver definition").
>
> And meanwhile it got copied to another function, usb_register_driver().
> I guess it's OK to fix both w/one patch?
Yes.
