On 8/18/20 8:29 PM, Alan Stern wrote:
>>> + } else {
>>> printk(KERN_ERR "%s: error %d registering device "
>>> " driver %s\n",
>>
>> Unrelated but... hm, this string literal seems weird. GregKH, would it be OK if we fix it?
>>
>>> usbcore_name, retval, new_udriver->name);
>
> Indeed, an extra tab character snuck in there by mistake. It has been
> present ever since 2006, when the routine was originally added by commit
> 8bb54ab573ec ("usbcore: add usb_device_driver definition").
And meanwhile it got copied to another function, usb_register_driver().
I guess it's OK to fix both w/one patch?
> It's perfectly okay with me if someone wants to remove the extra tab.
> In fact, nowadays we'd remove the line break entirely.
It seems this wasn't needed even in the 80-column era...
> Alan Stern
MBR, Sergei
