On Tue, Aug 18, 2020 at 08:06:20PM +0300, Sergei Shtylyov wrote:
> On 8/18/20 2:04 PM, Bastien Nocera wrote:
> > + } else {
> > printk(KERN_ERR "%s: error %d registering device "
> > " driver %s\n",
>
> Unrelated but... hm, this string literal seems weird. GregKH, would it be OK if we fix it?
>
> > usbcore_name, retval, new_udriver->name);
Indeed, an extra tab character snuck in there by mistake. It has been
present ever since 2006, when the routine was originally added by commit
8bb54ab573ec ("usbcore: add usb_device_driver definition").
It's perfectly okay with me if someone wants to remove the extra tab.
In fact, nowadays we'd remove the line break entirely.
Alan Stern
