Re: FTDI removal oops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 18, 2009 at 12:46:10AM +0100, David Woodhouse wrote:
> > Ok, good - thanks for testing. Would you care to send that with a
> > commit log and your sign-off?
> 
> I suppose so, if I drop the addition of cancel_delayed_work_sync() to
> ftdi_sio_port_remove(). That doesn't need to be there, AFAICT -- there
> can't be any work outstanding unless the device is open anyway. And the
> private data structure isn't going away until the device is closed... at
> which point the pending work gets flushed appropriately.

It was just moved in my original patch because there was no priv anymore
in the close routine where it was used to cancel the delayed work.

So yes, I also believe it does not need to be changed with the
simplified patch you provided.

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux