Re: FTDI removal oops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi David,

On Sun, May 17, 2009 at 10:39:02PM +0100, David Woodhouse wrote:
> > Daniel never replied to my last message, so I don't know what happens 
> > if one fixes his patch the way I suggested.
> 
> Yes, this fixes it.

Ok, good - thanks for testing. Would you care to send that with a commit
log and your sign-off?

Daniel


> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 0ab8474..2b870e6 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -1487,14 +1488,8 @@ static int ftdi_sio_port_remove(struct usb_serial_port *port)
>  
>  	remove_sysfs_attrs(port);
>  
> -	/* all open ports are closed at this point
> -	 *    (by usbserial.c:__serial_close, which calls ftdi_close)
> -	 */
> -
> -	if (priv) {
> -		usb_set_serial_port_data(port, NULL);
> -		kref_put(&priv->kref, ftdi_sio_priv_release);
> -	}
> +	cancel_delayed_work_sync(&priv->rx_work);
> +	kref_put(&priv->kref, ftdi_sio_priv_release);
>  
>  	return 0;
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux