On Thu, Apr 16, 2009 at 02:28:05PM +0200, Guennadi Liakhovetski wrote:
> Add OTG device definition and resources to i.MX31 and a pure USB device mode
> support to the pcm037 board.
>
> Signed-off-by: Guennadi Liakhovetski <lg@xxxxxxx>
> ---
>
> On Thu, 16 Apr 2009, Sascha Hauer wrote:
>
> > On Wed, Apr 15, 2009 at 10:34:57PM +0200, Guennadi Liakhovetski wrote:
> > >
> > > +static struct resource otg_resources[] = {
> > > + {
> > > + .start = OTG_BASE_ADDR,
> > > + .end = OTG_BASE_ADDR + 0x1ff,
> > > + .flags = IORESOURCE_MEM,
> > > + }, {
> > > + .start = MXC_INT_USB3,
> >
> > Don't we need the .end field?
>
> No, we don't. See platform_get_irq().
However, setting .end is preferable so that struct resource can be used
to specify a contiguous group of IRQs. I've always taken the approach
that setting .end doesn't cost any more bytes in the object, so it
might as well get set.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
