On Wed, Mar 04, 2009 at 04:52:55PM +0300, Sergei Shtylyov wrote: >>>> --- a/drivers/usb/gadget/dummy_hcd.c >>>> +++ b/drivers/usb/gadget/dummy_hcd.c >>>> @@ -1437,7 +1437,7 @@ restart: >>>> } >>>> if (urb->transfer_buffer_length > 1) >>>> buf [1] = 0; >>>> - urb->actual_length = min (2, >>>> + urb->actual_length = min ((u32)2, > >>> I'm not sure what this p[articular change gives us... > >> For this, and all other places you have questioned this, it fixes the >> compiler warning that would otherwise occur. A number is defined by the >> C standard as being an "int" unless you cast it, which is what these >> changes do. > >> So I think I'll leave it. > > Why not just use 2u then? Either way is the same in the end, (u32) makes it more obvious as to what is going on in my opinion. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html