Re: [PATCH] USB: do not convert negative transfer_buffer_lengths to positive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg KH wrote:

From foo@baz Tue Mar  3 16:44:13 PST 2009

  Interesting author. :-)

It's a mbox standard :)

--- a/drivers/usb/gadget/dummy_hcd.c
+++ b/drivers/usb/gadget/dummy_hcd.c
@@ -1437,7 +1437,7 @@ restart:
					}
					if (urb->transfer_buffer_length > 1)
						buf [1] = 0;
-					urb->actual_length = min (2,
+					urb->actual_length = min ((u32)2,

  I'm not sure what this p[articular change gives us...

For this, and all other places you have questioned this, it fixes the
compiler warning that would otherwise occur.  A number is defined by the
C standard as being an "int" unless you cast it, which is what these
changes do.

So I think I'll leave it.

   Why not just use 2u then?

thanks,

greg k-h

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux