Re: [PATCH] USB: do not convert negative transfer_buffer_lengths to positive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Sergei Shtylyov wrote:
>> --- a/drivers/usb/host/uhci-q.c
>> +++ b/drivers/usb/host/uhci-q.c
>> @@ -1498,7 +1498,7 @@ __acquires(uhci->lock)
>>           * complete successfully.  Either it failed or the URB was
>>           * unlinked first.  Regardless, don't confuse people with a
>>           * negative length. */
>> -        urb->actual_length = max(urb->actual_length, 0);
>> +        urb->actual_length = max(urb->actual_length, (u32)0);
> 
>    Why this is needed?

Greg:
	Since actual length now is unsigned it definitely can't be < 0
        This part of code is not needed anymore...

> 
>>      }
>>  
>>      /* When giving back the first URB in an Isochronous queue,

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux