Hi Giuseppe,
A few style comments
On Mon, Feb 09, 2009 at 10:22:29PM +0100, Giuseppe GORGOGLIONE wrote:
> From: Giuseppe GORGOGLIONE
this should be:
From: Giuseppe GORGOGLIONE <giuseppe.gorgoglione@xxxxxx>
> Corrected musb_read_fifosize() and musb_configure_ep0() functions
> for the #ifndef BLACKFIN branch,
>
> Signed-off-by: Giuseppe GORGOGLIONE <giuseppe.gorgoglione@xxxxxx>
don't tab there, please
> ---
>
> --- drivers/usb/musb/musb_core.h.orig 2009-02-09 20:54:17.000000000 +0100
> +++ drivers/usb/musb/musb_core.h 2009-02-09 21:36:25.000000000 +0100
> @@ -479,10 +479,11 @@ static inline void musb_configure_ep0(st
> static inline int musb_read_fifosize(struct musb *musb,
> struct musb_hw_ep *hw_ep, u8 epnum)
> {
> + void *mbase = musb->mregs;
> u8 reg = 0;
>
> /* read from core using indexed model */
> - reg = musb_readb(hw_ep->regs, 0x10 + MUSB_FIFOSIZE);
> + reg = musb_readb(mbase, MUSB_EP_OFFSET(epnum, MUSB_FIFOSIZE));
> /* 0's returned when no more endpoints */
> if (!reg)
> return -ENODEV;
> @@ -509,6 +510,7 @@ static inline void musb_configure_ep0(st
> {
> musb->endpoints[0].max_packet_sz_tx = MUSB_EP0_FIFOSIZE;
> musb->endpoints[0].max_packet_sz_rx = MUSB_EP0_FIFOSIZE;
> + musb->endpoints[0].is_shared_fifo = true;
> }
> #endif /* CONFIG_BLACKFIN */
Besides that, the patch is ok and should probably go to 2.6.29-rc
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
