On Mon, Feb 09, 2009 at 01:24:17PM +0100, Ajay Kumar Gupta wrote:
> As per latest musb tree, this portion of code is done in musb_configure_ep0()
> Due to BlackFin patches. BlackFin version already has this fix.
>
> #if BlackFin
> static inline void musb_configure_ep0(struct musb *musb)
> {
> musb->endpoints[0].max_packet_sz_tx = MUSB_EP0_FIFOSIZE;
> musb->endpoints[0].max_packet_sz_rx = MUSB_EP0_FIFOSIZE;
> musb->endpoints[0].is_shared_fifo = true;
> }
> #else
> static inline void musb_configure_ep0(struct musb *musb)
> {
> musb->endpoints[0].max_packet_sz_tx = MUSB_EP0_FIFOSIZE;
> musb->endpoints[0].max_packet_sz_rx = MUSB_EP0_FIFOSIZE;
> }
> #endif
> So I think its better to remove this inline function from musb_core.h
> And add it in musb_core.c itself. There is no need for BlackFin specific defs.
Hmm, sure... that still in Greg's queue right ?
Maybe Giuseppe could update his patch on top of Greg's queue then.
Giuseppe ? Any comments ?
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
