On Mon, Feb 09, 2009 at 02:13:13PM +0200, Felipe Balbi wrote:
> On Mon, Feb 09, 2009 at 01:24:17PM +0100, Ajay Kumar Gupta wrote:
> > As per latest musb tree, this portion of code is done in musb_configure_ep0()
> > Due to BlackFin patches. BlackFin version already has this fix.
> >
> > #if BlackFin
> > static inline void musb_configure_ep0(struct musb *musb)
> > {
> > musb->endpoints[0].max_packet_sz_tx = MUSB_EP0_FIFOSIZE;
> > musb->endpoints[0].max_packet_sz_rx = MUSB_EP0_FIFOSIZE;
> > musb->endpoints[0].is_shared_fifo = true;
> > }
> > #else
> > static inline void musb_configure_ep0(struct musb *musb)
> > {
> > musb->endpoints[0].max_packet_sz_tx = MUSB_EP0_FIFOSIZE;
> > musb->endpoints[0].max_packet_sz_rx = MUSB_EP0_FIFOSIZE;
> > }
> > #endif
> > So I think its better to remove this inline function from musb_core.h
> > And add it in musb_core.c itself. There is no need for BlackFin specific defs.
>
> Hmm, sure... that still in Greg's queue right ?
Greg's queue is flushed out and is in the linux-next tree. Please just
send patches based on that and you should be fine.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
