On Thu, 12 Feb 2009, Li Yang wrote: > On Thu, Feb 12, 2009 at 1:40 AM, Guennadi Liakhovetski <lg@xxxxxxx> wrote: > > MPC8313 / MPC8349 PPC SoCs and i.MX31 ARM SoCs use the same USB device > > core, extend the driver to support i.MX31. We just have to disable using > > Thanks a lot to make it work. Less change than what I expected. Yes, I also was surprised. But the problem with long control transfers has to be solved. Could someone verify if it also exists on original PPC platforms? I think, you should be able to reproduce it with the gadgetfs example from http://www.linux-usb.org/gadget/ > > usb_sys_interface and add clock management. > > Is the clock manipulating code board specific or chip specific? Chip-specific. > IMO, it's better to be placed under platform domain like we did for > PowerPC. That will make the driver cleaner as a common code for all > ARC USB controller. but then you'd need some callback. You do want to start and stop the clock on driver activation / deactivation. At least to save power when it's not running. We could add an i.MX31-specific file drivers/usb/gadget/fsl_imx31.c with just two functions to start and stop the clocks and define them as empty inlines in the header #ifndef ARCH_MX3? Or how would you prefer it? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@xxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
