On Tue, 2009-02-10 at 15:10 +0100, Sebastian Andrzej Siewior wrote:
> Current ifdefs could be cleaned up and you end up with one ifdef per type
> like:
>
> #ifdef CONFIG_PCI
>
> static int __devinit isp1761_pci_probe(struct pci_dev *dev,
> ....
>
> static int register_pci(void)
> {
> return pci_register_driver(&isp1761_pci_driver);
> }
> #else
> static int register_pci(void)
> {
> return 0;
> }
> static int unregister_pci(void)
> {
> return 0;
> }
> #endif
As I'm not familiar with PPC_OF, it is a bit unclear to me why in the
current driver, if pci_register_driver() fails, the driver needs to call
of_unregister_platform_driver(). Aren't these two pretty much
independent?
--
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
