Catalin Marinas wrote:
On Tue, 2009-02-10 at 14:17 +0100, Sebastian Andrzej Siewior wrote:
Russell King wrote:
> This is over complex - there's no need to mix -objs and -y together.
# Composite objects are specified in kbuild makefile as follows:
# <composite-object>-objs := <list of .o files>
# or
# <composite-object>-y := <list of .o files>
so:
isp1760-y := isp1760-hcd.o isp1760-plat.o
isp1760-$(CONFIG_PPC_OF) += isp1760-if.o
isp1760-$(CONFIG_PCI) += isp1760-if.o
does just as well.
Yep. could we merge this into the -if.c file? Any objections?
Too many #ifdef's?
Current ifdefs could be cleaned up and you end up with one ifdef per type
like:
#ifdef CONFIG_PCI
static int __devinit isp1761_pci_probe(struct pci_dev *dev,
....
static int register_pci(void)
{
return pci_register_driver(&isp1761_pci_driver);
}
#else
static int register_pci(void)
{
return 0;
}
static int unregister_pci(void)
{
return 0;
}
#endif
and this looks okey to me. According to your other mail, platform devices
are always available so no new ifdefs.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
