Catalin Marinas wrote:
This looks like it based on my -if.c code and is not totally written by
you as the copyright says.
Well, I used yours more as inspiration rather than copy/paste but I'm
happy to add your copyright as well. This may not make sense anyway if
you'd like it merged into isp1760-if.c (though I even had a thought of
splitting isp1760-if.c into -pci and -ppcof files).
If you split, we end up with tiny files. If you look at the libertas
driver in drivers/net/wireless they have a usb bus, sdio, spi, ... and
each bus type has more code. In such a case I would also prefer to make
one file for each bus type.
The more important thing is that you use init_kmem_ince() and
deinit_kmem_cache() and this breaks the PCI/OF part if it used at the same
time.
That's a reason to merge it into the -if file. The alternative is to
make init_kmem_once() smarter to now whether it was already initialised.
Smarter means soemthing like ref counting and I don't like it for such a
simple case.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
