Re: [PATCH] Add platform device support for the ISP1760 USB chip

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2009-02-10 at 15:10 +0100, Sebastian Andrzej Siewior wrote:
> Catalin Marinas wrote:
> > On Tue, 2009-02-10 at 14:17 +0100, Sebastian Andrzej Siewior wrote:
> >> Russell King wrote:
> >>   > This is over complex - there's no need to mix -objs and -y together.
> >>> #  Composite objects are specified in kbuild makefile as follows:
> >>> #    <composite-object>-objs := <list of .o files>
> >>> #  or
> >>> #    <composite-object>-y    := <list of .o files>
> >>>
> >>> so:
> >>>
> >>> isp1760-y			:= isp1760-hcd.o isp1760-plat.o
> >>> isp1760-$(CONFIG_PPC_OF)	+= isp1760-if.o
> >>> isp1760-$(CONFIG_PCI)		+= isp1760-if.o
> >>>
> >>> does just as well.
> >> Yep. could we merge this into the -if.c file? Any objections?
> > 
> > Too many #ifdef's?
> > 
[...]
> According to your other mail, platform devices 
> are always available so no new ifdefs.

OK, it makes sense. I'll implement your and Russell's comments and
re-post.

Thanks.

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux