On Tue, 2009-02-10 at 14:24 +0100, Sebastian Andrzej Siewior wrote:
> Catalin Marinas wrote:
> > In addition, it changes the function prototype for the
> > isp1760_register() function to use predefined types like phys_addr_t and
> > size_t rather than u64.
> Please make this a separate patch.
OK.
> > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> > index 2c63bfb..56de061 100644
> > --- a/drivers/usb/host/Kconfig
> > +++ b/drivers/usb/host/Kconfig
> > @@ -123,7 +123,7 @@ config USB_ISP116X_HCD
> >
> > config USB_ISP1760_HCD
> > tristate "ISP 1760 HCD support"
> > - depends on USB && EXPERIMENTAL && (PCI || PPC_OF)
> > + depends on USB && EXPERIMENTAL
> Platform device support is always present I guess.
Yes.
> > +static int __init isp1760_init(void)
> > +{
> > + int ret;
> > +
> > + ret = init_kmem_once();
> > + if (ret)
> > + goto out;
> > + ret = platform_driver_register(&isp1760_driver);
> > + if (ret)
> > + deinit_kmem_cache();
> > +out:
> > + return ret;
> > +}
> > +module_init(isp1760_init);
> > +
> > +static void __exit isp1760_exit(void)
> > +{
> > + platform_driver_unregister(&isp1760_driver);
> > + deinit_kmem_cache();
> > +}
> > +module_exit(isp1760_exit);
> This looks like it based on my -if.c code and is not totally written by
> you as the copyright says.
Well, I used yours more as inspiration rather than copy/paste but I'm
happy to add your copyright as well. This may not make sense anyway if
you'd like it merged into isp1760-if.c (though I even had a thought of
splitting isp1760-if.c into -pci and -ppcof files).
> The more important thing is that you use init_kmem_ince() and
> deinit_kmem_cache() and this breaks the PCI/OF part if it used at the same
> time.
That's a reason to merge it into the -if file. The alternative is to
make init_kmem_once() smarter to now whether it was already initialised.
--
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
