Catalin Marinas wrote:
As I'm not familiar with PPC_OF, it is a bit unclear to me why in the current driver, if pci_register_driver() fails, the driver needs to call of_unregister_platform_driver(). Aren't these two pretty much independent?
Yes, they are independent. Both register routines should not fail under normal circumstances. Therefore if one of them fails we remove / unload the other bus and report the error to the caller (i.e. modprobe). The alternative is to track which bus binding failed and skip those in the module exit path. This isn't worth it IMHO. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html