Arnd Bergmann <arnd@xxxxxxxx> writes: > This addresses both issues by moving all the definitions into the > pxa25x_udc driver itself. It turns out the only difference between > them was 'UDCCS_IO_ROF', and that could well be a mistake when it > was incorrectly copied from pxa25x to ixp4xx. > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> Both the programming manual and the Intel's library code say it's bit 2. Must be a mistake in the old code. Unfortunately I think we won't be able to check it on real hardware, the UDC on IXP4xx boards isn't usually connected. Also, this bug wouldn't likely affect operation (unless there is an overflow event, which would be currently undetected). I guess we as well very safely change it to 1 << 2. For the IXP4xx part, Acked-by: Krzysztof Halasa <khalasa@xxxxxxx> -- Krzysztof Halasa Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
