Arnd Bergmann <arnd@xxxxxxxx> writes: > On Friday 29 January 2016 10:32:07 Robert Jarzmik wrote: >> > This addresses both issues by moving all the definitions into the >> > pxa25x_udc driver itself. It turns out the only difference between >> > them was 'UDCCS_IO_ROF', and that could well be a mistake when it >> > was incorrectly copied from pxa25x to ixp4xx. >> Hi Arnd, >> >> Is there a reason to have chosen to move into pxa25_udc.c instead of >> drivers/usb/gadget/udc/pxa25x_udc.h ? pxa27x_udc has a .h in the same directory >> with register definitions, hence the question. > > Yes: The register definitions are only used in a single .c file and > are not an interface between files, so it's better to have them in > the file that uses them. > > I could have continued the cleanup and moved the two headers into the > respective drivers as well, but I had to stop somewhere ;-) Fair enough. Acked-by: Robert Jarzmik <robert.jarzmik@xxxxxxx> Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
