Re: [PATCH 1/2] Add can_do_streams to dummy_hcd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 30 May 2014 pktoss@xxxxxxxxx wrote:

> From: Pantelis Koukousoulas <pktoss@xxxxxxxxx>
> 
> Recent commit (14aec589327a6fc4035f5327d90ac5548f501c4c) added the
> "can_do_streams" field to the hcd structure but only set it to 1
> in the XHCI driver.
> 
> dummy_hcd can also do streams so set can_do_streams = 1 for that
> as well.
> 
> This fixes the regression that uas host driver stopped accepting
> to bind to the tcm_usb_gadget under dummy_hcd after the offending
> commit above.
> ---
>  drivers/usb/gadget/dummy_hcd.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
> index 8c06430..67ebf90 100644
> --- a/drivers/usb/gadget/dummy_hcd.c
> +++ b/drivers/usb/gadget/dummy_hcd.c
> @@ -2544,6 +2544,8 @@ static int dummy_hcd_probe(struct platform_device *pdev)
>  		retval = usb_add_hcd(ss_hcd, 0, 0);
>  		if (retval)
>  			goto put_usb3_hcd;
> +
> +		ss_hcd->can_do_streams = 1;

This line needs to go before usb_add_hcd(), not after.

>  	}
>  	return 0;

Fix that up and then you can add:

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux