On Mon, Apr 21, 2014 at 06:07:50PM +0200, Daniel Mack wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 04/15/2014 07:21 PM, Felipe Balbi wrote:
> > On Wed, Apr 02, 2014 at 03:21:44PM +0200, Daniel Mack wrote:
> >> On 04/02/2014 02:12 PM, Sergei Shtylyov wrote:
> >>> On 02-04-2014 15:58, Daniel Mack wrote:
> >>>> +static inline void musb_platform_reset(struct musb *musb)
> >>>> +{ + if (musb->ops->reset) + musb->ops->reset(musb); +} +
> >>>
> >>> I think this patch should be merged with the patch #2. It's not
> >>> good that you add a function that's not called yet.
> >>
> >> Well, that's common practice in the kernel I'd say in order to
> >> keep the changes small. But it's a matter of maintainer's taste
> >> after all, so if Felipe wants me to, I can easily squash the two
> >> together.
> >
> > don't worry, when it comes to inlines, I prefer to see them
> > introduced then used. There will be no warnings or errors added
> > because of a new inline function being added.
> >
>
> Alright, thanks. What do you think about the rest of this series that
> recovers from the babble Interrupt condition? Are the patches good to in?
playing with them as we speak :-)
--
balbi
Attachment:
signature.asc
Description: Digital signature
