On 04/02/2014 02:12 PM, Sergei Shtylyov wrote: > On 02-04-2014 15:58, Daniel Mack wrote: >> +static inline void musb_platform_reset(struct musb *musb) >> +{ >> + if (musb->ops->reset) >> + musb->ops->reset(musb); >> +} >> + > > I think this patch should be merged with the patch #2. It's not good that > you add a function that's not called yet. Well, that's common practice in the kernel I'd say in order to keep the changes small. But it's a matter of maintainer's taste after all, so if Felipe wants me to, I can easily squash the two together. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html