Re: [PATCH 1/3] USB: musb: add reset hook to platform ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02-04-2014 15:58, Daniel Mack wrote:

Babble interrupts require us to reset the DSPS glue layer. In order to
handle all other recovery tasks independently, add a new hook for
platform-specific implementations of the actual reset.

Signed-off-by: Daniel Mack <zonque@xxxxxxxxx>
---
  drivers/usb/musb/musb_core.h | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h
index 7083e82..5514e4c 100644
--- a/drivers/usb/musb/musb_core.h
+++ b/drivers/usb/musb/musb_core.h
@@ -192,6 +192,7 @@ struct musb_platform_ops {

  	int	(*set_mode)(struct musb *musb, u8 mode);
  	void	(*try_idle)(struct musb *musb, unsigned long timeout);
+	void	(*reset)(struct musb *musb);

  	int	(*vbus_status)(struct musb *musb);
  	void	(*set_vbus)(struct musb *musb, int on);
@@ -552,6 +553,12 @@ static inline void musb_platform_try_idle(struct musb *musb,
  		musb->ops->try_idle(musb, timeout);
  }

+static inline void musb_platform_reset(struct musb *musb)
+{
+	if (musb->ops->reset)
+		musb->ops->reset(musb);
+}
+

I think this patch should be merged with the patch #2. It's not good that you add a function that's not called yet.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux