Re: [RFC 0/2] Support for Super Speed Link Layer Test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 15, 2014 at 02:20:13AM +0800, Alan Stern wrote:
> On Mon, 14 Apr 2014, Pratyush Anand wrote:
> 
> > Hi Alan,
> > 
> > On Fri, Apr 11, 2014 at 06:56:37PM +0800, Pratyush ANAND wrote:
> > > Lecroy's USB Compliance suites provide option to test Link Layer Tests
> > > for Super Speed device as well as host.
> > > 
> > > As of now there is no standard way to test embedded host for these
> > > tests.
> > > 
> > > These patches modifies Linux USB host stack to carry out these tests for
> > > embedded hosts. Modifications are still not complete. Patch 2 will have
> > > few more sysfs nodes to support some failing tests. 
> > > 
> > > I am sending these as RFC for mainly to have your comment on framework
> > > modifications. Please let me know, if there could be any better way to
> > > do it.
> > 
> > Do you see a better way of doing it than this implementation (which is
> > creating a platform device for each new connection request from Link
> > Layer Validation (LVS) device)?
> 
> How about just creating a normal USB device instead of a platform 
> device?  I think all you have to do is make usb_new_device() avoid 
> calling usb_enumerate_device() when the new flag is set.

I had thought of this. But, I had found that even hub_port_reset
creates issue for LVS device. hub_port_reset forces USB SS link to go
into recovery very soon, which is not expected as per Link Layer Test
specification. So, we can not even allow to execute hub_port_init when
a LVS device is connected.

> 
> Also, instead of adding a new quirk flag to every single USB device, 
> you probably should use something that is hcd-specific.  Then xhci-hcd 
> could register the new sysfs file, and it wouldn't be present for other 
> controller types or non-root hubs.

That I will look into. Should be doable.

Regards
Pratyush
> 
> Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux