Johan Hovold <jhovold@xxxxxxxxx> writes:
> [ +CC: Dan and Bjørn ]
>
> On Fri, Mar 28, 2014 at 03:25:06PM +0800, AceLan Kao wrote:
>> This patch adds support for Dell Computer Corp. Wireless 5808e 4G LTE
>> Mobile Broadband Card.
>
> Shouldn't this device be handled by the option driver?
>
> In fact, PID 0x8133 for 5720 VZW (which your clean-up patch touches)
> is listed in both option and sierra.
>
> I think we need to revert 1ebca9dad5ab ("USB: serial: add usbid for dell
> wwan card to sierra.c").
Maybe. If nothing else, additional PID digit in that patch looks a bit
silly :-)
It would be good to have a bit more information about these modules. As
you know, but the reporters may not be aware of, the fact that they are
made by Sierra does not necessarily mean that they are supported by the
sierra driver. That will depend on the chipset and firmware.
Just as an example: My Sierra Wireless MC7710 works fine with the sierra
driver if it is in "DirectIP" mode (using a 0x68a3 PID). But it fails
the sierra_set_power_state() control message I configure it for "QMI"
mode (using a 0x68a2 PID), adding a 5 second delay for every serial port
probed. This delay isn't necessarily noticed by the reporter... The
0x68a2 PID was also originally added to the sierra driver, and it did
sort of work.
I think we'd like to see at least a dmesg snippet with time stamps
showing the actual probing before accepting any new device into the
"sierra" driver. We do not want to add any device which does not
understand the Sierra vendor specific control messages.
And it would also be preferable to have a lsusb -v listing or similar,
so that we can match the different functions against other Sierra
devices. Sierra have been using a system with fixed interface numbers
for different vendor specific functions lately. The sierra driver has
knowledge about this. That's what the &direct_ip_interface_blacklist is
for. I'm pretty sure that any new Sierra module will need to have this
blacklist enabled, even if it turns out that the sierra driver is
correct.
Bjørn
>> Signed-off-by: AceLan Kao <acelan.kao@xxxxxxxxxxxxx>
>> ---
>> drivers/usb/serial/sierra.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
>> index b78fd4e..961d586 100644
>> --- a/drivers/usb/serial/sierra.c
>> +++ b/drivers/usb/serial/sierra.c
>> @@ -292,6 +292,7 @@ static const struct usb_device_id id_table[] = {
>> .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
>> },
>> { USB_DEVICE(0x413C, 0x8133) }, /* Dell Computer Corp. Wireless 5720 VZW Mobile Broadband (EVDO Rev-A) Minicard GPS Port */
>> + { USB_DEVICE(0x413C, 0x81A9) }, /* Dell Computer Corp. Wireless 5808e 4G LTE Mobile Broadband Card */
>>
>> { }
>> };
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
