Hi,
On 03/28/2014 11:14 AM, oliver@xxxxxxxxxx wrote:
> From: Oliver Neukum <oneukum@xxxxxxx>
>
> There is an allocation with GFP_NOIO with a spinlock
> held that the checker didn't catch.
I hate to be a PITA, but this above part of the commit message is no longer
correct, can you amend the commit message and resend please ?
Thanks,
Hans
> There are also two allocations with GFP_KERNEL in the pre-/post_reset
> code paths. That is no good because that is a part of the SCSI error handler.
>
> Signed-off-by: Oliver Neukum <oliver@xxxxxxxxxx>
> ---
> drivers/usb/storage/uas.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
> index 8f42226..b2bd8ea 100644
> --- a/drivers/usb/storage/uas.c
> +++ b/drivers/usb/storage/uas.c
> @@ -1030,7 +1030,7 @@ static int uas_configure_endpoints(struct uas_dev_info *devinfo)
> devinfo->use_streams = 0;
> } else {
> devinfo->qdepth = usb_alloc_streams(devinfo->intf, eps + 1,
> - 3, 256, GFP_KERNEL);
> + 3, 256, GFP_NOIO);
> if (devinfo->qdepth < 0)
> return devinfo->qdepth;
> devinfo->use_streams = 1;
> @@ -1047,7 +1047,7 @@ static void uas_free_streams(struct uas_dev_info *devinfo)
> eps[0] = usb_pipe_endpoint(udev, devinfo->status_pipe);
> eps[1] = usb_pipe_endpoint(udev, devinfo->data_in_pipe);
> eps[2] = usb_pipe_endpoint(udev, devinfo->data_out_pipe);
> - usb_free_streams(devinfo->intf, eps, 3, GFP_KERNEL);
> + usb_free_streams(devinfo->intf, eps, 3, GFP_NOIO);
> }
>
> static int uas_probe(struct usb_interface *intf, const struct usb_device_id *id)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
